Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make psalm run on pushes to protected branches #1131

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling 213943+nickvergessen@users.noreply.github.com

Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
@skjnldsv
Copy link
Member

@skjnldsv skjnldsv merged commit 1197780 into master Aug 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the nickvergessen-patch-1 branch August 18, 2022 07:50
@nickvergessen
Copy link
Member Author

Wut, it passes? https://github.com/nextcloud/circles/runs/7877169613?check_suite_focus=true

Yeah because it used the old lib because #1133 was not there. it didn't reinstall newest master?

@nickvergessen
Copy link
Member Author

Also I was refering to pushes, not PRs/merges.
E.g. Translations which therefor run psalm on a regular basis:
https://github.com/nextcloud/circles/actions/workflows/static-analysis.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants