Skip to content

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Apr 20, 2022

Currently, most of the issues reported by psalm are ignored, I just fixed a few one. But at least this will ensure the number of issues reported doesn't increase

@codecov-commenter
Copy link

Codecov Report

Merging #1024 (17e5f52) into master (d154a50) will decrease coverage by 0.00%.
The diff coverage is 1.76%.

❗ Current head 17e5f52 differs from pull request most recent head 01eec12. Consider uploading reports for the commit 01eec12 to get more accurate results

@@             Coverage Diff             @@
##             master   #1024      +/-   ##
===========================================
- Coverage      0.70%   0.69%   -0.01%     
- Complexity     5688    5741      +53     
===========================================
  Files           289     291       +2     
  Lines         19686   19862     +176     
===========================================
+ Hits            138     139       +1     
- Misses        19548   19723     +175     
Impacted Files Coverage Δ
lib/Circles/FileSharingBroadcaster.php 0.00% <0.00%> (ø)
lib/CirclesManager.php 0.00% <0.00%> (ø)
lib/Command/CirclesConfig.php 0.00% <0.00%> (ø)
lib/Command/CirclesList.php 0.00% <0.00%> (ø)
lib/Command/CirclesMaintenance.php 0.00% <0.00%> (ø)
lib/Command/CirclesMemberships.php 0.00% <0.00%> (ø)
lib/Controller/AdminController.php 15.54% <0.00%> (ø)
lib/Controller/EventWrapperController.php 0.00% <0.00%> (ø)
lib/Cron/Maintenance.php 0.00% <0.00%> (ø)
lib/Cron/MaintenanceHeavy.php 0.00% <0.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d154a50...01eec12. Read the comment docs.

@blizzz blizzz added this to the Nextcloud 25 milestone Apr 21, 2022
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan merged commit 45934f5 into master Apr 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the feat/psalm branch April 26, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants