Skip to content

Commit 3d686b3

Browse files
Merge pull request #2015 from nextcloud/backport/1969/stable31
2 parents be3d0f5 + de0e744 commit 3d686b3

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

lib/Command/MembersList.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ private function getMembers(
307307
}
308308
} else {
309309
$this->federatedUserService->commandLineInitiator($initiator, $initiatorType, $circleId, true);
310-
$members = $this->memberService->getMembers($circleId);
310+
$members = $this->memberService->getMembers($circleId, true);
311311
}
312312

313313
if (!is_null($tree)) {

lib/Controller/RemoteController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ public function members(string $circleId): DataResponse {
306306
}
307307

308308
try {
309-
$members = $this->memberService->getMembers($circleId);
309+
$members = $this->memberService->getMembers($circleId, true);
310310

311311
return new DataResponse($members);
312312
} catch (Exception $e) {

lib/Db/MemberRequest.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,7 @@ public function getMembers(
199199
?IFederatedUser $initiator = null,
200200
?MemberProbe $probe = null,
201201
int $limit = 0,
202+
bool $fullDetails = false,
202203
): array {
203204
if (is_null($probe)) {
204205
$probe = new MemberProbe();
@@ -218,8 +219,10 @@ public function getMembers(
218219
)
219220
);
220221

221-
$qb->leftJoinCircle(CoreQueryBuilder::MEMBER, $initiator);
222-
$qb->leftJoinInvitedBy(CoreQueryBuilder::MEMBER);
222+
if ($fullDetails) {
223+
$qb->leftJoinCircle(CoreQueryBuilder::MEMBER, $initiator);
224+
$qb->leftJoinInvitedBy(CoreQueryBuilder::MEMBER);
225+
}
223226

224227
if ($probe->hasFilterRemoteInstance()) {
225228
$aliasCircle = $qb->generateAlias(CoreQueryBuilder::MEMBER, CoreQueryBuilder::CIRCLE);

lib/Service/MemberService.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ public function getMemberById(
151151
* @throws InitiatorNotFoundException
152152
* @throws RequestBuilderException
153153
*/
154-
public function getMembers(string $circleId): array {
154+
public function getMembers(string $circleId, bool $fullDetails = false): array {
155155
$this->federatedUserService->mustHaveCurrentUser();
156156

157157
$probe = new MemberProbe();
@@ -164,7 +164,8 @@ public function getMembers(string $circleId): array {
164164
return $this->memberRequest->getMembers(
165165
$circleId,
166166
$this->federatedUserService->getCurrentUser(),
167-
$probe
167+
$probe,
168+
fullDetails: $fullDetails
168169
);
169170
}
170171

0 commit comments

Comments
 (0)