Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete X-ALT-DESC property value on changing the description #4744

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Nov 18, 2022

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny added the 3. to review Waiting for reviews label Nov 18, 2022
@st3iny st3iny added this to the v4.2.0 milestone Nov 18, 2022
@st3iny st3iny self-assigned this Nov 18, 2022
@st3iny
Copy link
Member Author

st3iny commented Nov 18, 2022

/backport to stable4.1

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Nov 18, 2022
@st3iny
Copy link
Member Author

st3iny commented Nov 18, 2022

/backport to stable3.5

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 41.57% // Head: 41.56% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (fa85fa3) compared to base (f32aa88).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4744      +/-   ##
============================================
- Coverage     41.57%   41.56%   -0.01%     
  Complexity      338      338              
============================================
  Files           225      225              
  Lines          5638     5639       +1     
  Branches        738      738              
============================================
  Hits           2344     2344              
- Misses         3294     3295       +1     
Flag Coverage Δ
javascript 31.42% <0.00%> (-0.01%) ⬇️
php 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/store/calendarObjectInstance.js 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@st3iny st3iny merged commit 748369e into main Nov 18, 2022
@st3iny st3iny deleted the fix/3863/delete-custom-desc-prop branch November 18, 2022 12:28
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 18, 2022
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request A backport was requested for this pull request label Nov 18, 2022
@benbucksch
Copy link

@st3iny Thank you for picking this up, and fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
Development

Successfully merging this pull request may close these issues.

3 participants