Skip to content

Conversation

@lukasdotcom
Copy link
Member

@lukasdotcom lukasdotcom commented Jul 30, 2025

Returning a ProxyResponse with a transfer-encoding header causes the response to be cut off and nothing to be returned this removes the transfer-encoding header when it is set to chunking. MCP servers respond with that header breaking the proxy.

Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
@lukasdotcom lukasdotcom requested a review from bigcat88 July 30, 2025 16:55
Copy link
Contributor

@oleksandr-nc oleksandr-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I give approval in advance(very nice fix!), but it would be nice to add a short description of the PR.

@lukasdotcom
Copy link
Member Author

/backport to stable31

@lukasdotcom lukasdotcom merged commit cc6bc8a into main Jul 30, 2025
34 checks passed
@lukasdotcom lukasdotcom deleted the transfer-encoding branch July 30, 2025 17:14
@lukasdotcom
Copy link
Member Author

I give approval in advance(very nice fix!), but it would be nice to add a short description of the PR.

Should this be backported to stable30 also?

@oleksandr-nc
Copy link
Contributor

Should this be backported to stable30 also?

yes, why not.

@lukasdotcom
Copy link
Member Author

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants