Skip to content

Conversation

@lukasdotcom
Copy link
Member

AppApi adjustment for cloud-py-api/nc_py_api#346

@marcelklehr
Copy link
Member

We should probably continue to support the old version as well

…ssistant

Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
@lukasdotcom
Copy link
Member Author

Adjusted the changes to validate it how nc_py sent it, and modified the transformation to have it be correct for the assistant to use it.

@lukasdotcom
Copy link
Member Author

We should probably continue to support the old version as well

That shouldn't be necessary anymore if we are just keeping the old behavior for cloud-py-api/nc_py_api#346 and just ensuring that passes validation.

Copy link
Collaborator

@kyteinsky kyteinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks a lot!

@kyteinsky
Copy link
Collaborator

That shouldn't be necessary anymore if we are just keeping the old behavior for cloud-py-api/nc_py_api#346 and just ensuring that passes validation.

that was before the discussion with him I believe.

@oleksandr-nc
Copy link
Contributor

I can tomorrow check this PR with our AI apps.

@kyteinsky @marcelklehr should we backport it or not?

@kyteinsky
Copy link
Collaborator

should we backport it or not?

should be good to imo

@oleksandr-nc oleksandr-nc merged commit 73d25a8 into nextcloud:main Apr 24, 2025
36 checks passed
@oleksandr-nc
Copy link
Contributor

Thanks @lukasdotcom !

@oleksandr-nc
Copy link
Contributor

/backport to stable31

@oleksandr-nc
Copy link
Contributor

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants