-
Couldn't load subscription status.
- Fork 14
Fix task processing registration validation #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix task processing registration validation #548
Conversation
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
|
We should probably continue to support the old version as well |
…ssistant Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
|
Adjusted the changes to validate it how nc_py sent it, and modified the transformation to have it be correct for the assistant to use it. |
That shouldn't be necessary anymore if we are just keeping the old behavior for cloud-py-api/nc_py_api#346 and just ensuring that passes validation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect, thanks a lot!
that was before the discussion with him I believe. |
|
I can tomorrow check this PR with our AI apps. @kyteinsky @marcelklehr should we backport it or not? |
should be good to imo |
|
Thanks @lukasdotcom ! |
|
/backport to stable31 |
|
/backport to stable30 |
AppApi adjustment for cloud-py-api/nc_py_api#346