Skip to content

fix(share-activity): ui/ux#17025

Open
alperozturk96 wants to merge 5 commits into
masterfrom
fix/file-edit-share
Open

fix(share-activity): ui/ux#17025
alperozturk96 wants to merge 5 commits into
masterfrom
fix/file-edit-share

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 commented May 11, 2026 •
edited
Loading

Issue

User can navigate share detail fragment from ShareActivity thus it needs to show exact same UI just like navigated from file listing.

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot_20260511_131504 Screenshot_20260521_105916

Changes

  • Fixes UI
  • Fixes thumbnail generation
  • Allow user to go back properly
  • Converts to Kotlin

@alperozturk96
Copy link
Copy Markdown
Collaborator Author

alperozturk96 commented May 11, 2026

/backport to stable-33.1.x

@alperozturk96 alperozturk96 added this to the Nextcloud App 33.1.1 milestone May 11, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

APK file: https://github.com/nextcloud/android/actions/runs/25666816079/artifacts/6917748718
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

tobiasKaminsky

This comment was marked as resolved.

Sign in to view

@alperozturk96
Rename .java to .kt
cd9937a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix(share-activity): ui/ux
2e8ac4a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix(share-activity): ui/ux
28dbfc9 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix(share-activity): ui/ux
c993245 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/file-edit-share branch from 4d4211e to c993245 Compare May 21, 2026 07:05
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

APK file: https://github.com/nextcloud/android/actions/runs/26210961898/artifacts/7129388905
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
use dialog
270297a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness6767
Dodgy code216215
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total420419

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

APK file: https://github.com/nextcloud/android/actions/runs/26213365437/artifacts/7130426996
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review backport-request

Projects

None yet

Milestone

Nextcloud App 33.1.1

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @tobiasKaminsky