ci: harden integration test script and improve logcat handling #16010
+19
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR improves the stability, safety, and maintainability of the integration test Bash script used in the Android CI pipeline. ### ✔ Summary of Improvements This update focuses on hardening the script and preventing silent failures, unexpected behavior, and log corruption during integration test execution. ### 🔧 Key Changes - Enabled strict Bash mode (`set -euo pipefail`) to ensure the script stops on errors, avoids undefined variables, and surfaces pipeline failures. - Quoted all variable expansions to prevent word-splitting, globbing, and incorrect argument parsing during CI execution. - Replaced the hardcoded Codecov token with a secure environment variable (`$CODECOV_TOKEN`) to avoid credential leakage in the repository. - Added proper cleanup logic for the background `adb logcat` process, using: - `wait "$LOGCAT_PID"` to flush any buffered output - `kill "$LOGCAT_PID" 2>/dev/null || true` to avoid CI crashes if the process exits early - Improved the reliability of logcat upload logic and ensured that log files are preserved whenever an integration test step fails. - Ensured correct exit code propagation so that Drone CI reflects accurate build/test results. - General scripting cleanup and modernization to better align with Bash best practices and CI reproducibility. ### 💡 Why These Changes Matter The previous version of the script: - could continue execution after failed commands, - could kill unrelated processes or truncate log output, - exposed a sensitive token in plain text, - did not properly handle asynchronous processes, - could cause inconsistent CI behavior depending on the environment. With these improvements, the integration test pipeline becomes: - more secure, - more deterministic, - easier to debug, - and safer for automated execution. ### 🧪 Testing Notes Only CI-related behavior was modified. No app logic was touched. This PR has been tested across multiple invocations to confirm stable behavior and proper log handling. --- This PR does not affect end users but significantly improves CI reliability for maintainers and contributors. Signed-off-by: Gorlesunilkumar <g2005.sunil2005@gmail.com>
Author
|
merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the stability, safety, and reliability of the integration
test Bash script used in the Android CI pipeline.
✔ Summary of Improvements
The update focuses on modernizing the script, preventing silent failures, and
ensuring logcat output is reliably collected and uploaded when tests fail.
🔧 Key Changes
set -euo pipefail) for safer executionwait "$LOGCAT_PID"to flush outputkill "$LOGCAT_PID" 2>/dev/null || trueto avoid CI crashes💡 Why This Matters
The previous script:
This update makes integration tests more secure, deterministic, and easier to
debug—benefiting both maintainers and contributors.
🧪 Testing Notes
Only CI-related behavior was modified.
No application logic is affected.
This PR does not change app functionality for users but significantly improves
CI maintainability and reliability.