fix(file-sort): concurrent modification exception

[alperozturk96]

• Tests written, or not not needed

Fixes

Exception java.util.ConcurrentModificationException:
  at java.util.ArrayList.sort (ArrayList.java:1823)
  at java.util.Collections.sort (Collections.java:207)
  at kotlin.collections.CollectionsKt__MutableCollectionsJVMKt.sortWith (MutableCollectionsJVM.kt:42)
  at com.owncloud.android.utils.FileSortOrderByDate.sortLocalFiles (FileSortOrderByDate.kt:51)
  at com.owncloud.android.ui.adapter.LocalFileListAdapter.lambda$setSortOrder$6 (LocalFileListAdapter.java:392)
  at com.owncloud.android.ui.adapter.LocalFileListAdapter.$r8$lambda$WTDJyclhOx9wYl9P9c9Mv0A876o (Unknown Source)
  at com.owncloud.android.ui.adapter.LocalFileListAdapter$$ExternalSyntheticLambda3.run (D8$$SyntheticClass)
  at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1156)
  at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:651)
  at java.lang.Thread.run (Thread.java:1119)

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15985.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	42	42
Correctness	73	73
Dodgy code	272	272
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	35	36
Performance	48	48
Security	18	18
Total	498	499

SpotBugs increased!