Skip to content

Finish PreviewImageActivity After Image Deletion #14782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Finish PreviewImageActivity After Image Deletion #14782

wants to merge 1 commit into from
+4 −0

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Apr 11, 2025 •
edited
Loading

  • Tests written, or not not needed

How to reproduce?

  1. Create a folder and upload two image files of the same type.
  2. Tap on one of the image files to open its preview, then delete it from there.
  3. Repeat the same process for an encrypted folder.
  4. App gets stuck in the PreviewImageActivity

@alperozturk96
finishPreviewImageActivity
239ae3c 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 requested review from tobiasKaminsky and removed request for tobiasKaminsky April 11, 2025 14:46
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5454
Errors1111

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code292292
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5151
Security1818
Total500500

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14782.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2. developing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alperozturk96