Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] Various fixes #1759

Merged
merged 2 commits into from
Aug 29, 2024
Merged

[stable30] Various fixes #1759

merged 2 commits into from
Aug 29, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 28, 2024

Backport of #1758

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Signed-off-by: Louis Chemineau <louis@chmn.me>
This way it can be properly compared with plugin activities

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge marked this pull request as ready for review August 28, 2024 10:23
Copy link

cypress bot commented Aug 28, 2024

Activity    Run #1893

Run Properties:  status check failed Failed #1893  •  git commit 4e0c39e36f: [stable30] Various fixes
Project Activity
Branch Review backport/1758/stable30
Run status status check failed Failed #1893
Run duration 03m 26s
Commit git commit 4e0c39e36f: [stable30] Various fixes
Committer backportbot[bot]
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 8
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/sidebar.cy.ts • 2 failed tests • Run E2E

View Output

Test Artifacts
Check activity listing in the sidebar > Has share activity Test Replay Screenshots
Check activity listing in the sidebar > Has tag activity Test Replay Screenshots

@artonge artonge enabled auto-merge August 28, 2024 16:17
@artonge artonge disabled auto-merge August 29, 2024 08:53
@artonge artonge merged commit d48879b into stable30 Aug 29, 2024
48 of 52 checks passed
@artonge artonge deleted the backport/1758/stable30 branch August 29, 2024 08:53
@blizzz blizzz mentioned this pull request Aug 29, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant