Skip to content

#400 Make NextcloudAPI constructor less verbose #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stefan-niedermann
Copy link
Member

See #400 Make NextcloudAPI constructor less verbose, reduce boilerplate code.

Signed-off-by: Stefan Niedermann info@niedermann.it

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann stefan-niedermann linked an issue Nov 5, 2021 that may be closed by this pull request
@stefan-niedermann stefan-niedermann added the 3. to review Waiting for reviews label Nov 5, 2021
@David-Development
Copy link
Member

@stefan-niedermann Beautiful! I like the default interface implementation! Looks great to me - now I can refactor the news app to implement the new constructor 😅

@stefan-niedermann stefan-niedermann merged commit 681652f into master Nov 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the 400-make-nextcloudapi-constructor-less-verbose branch November 6, 2021 10:32
@stefan-niedermann stefan-niedermann removed the 3. to review Waiting for reviews label Nov 6, 2021
@stefan-niedermann stefan-niedermann added this to the SSO Library 0.6.0 milestone Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make NextcloudAPI constructor less verbose
2 participants