Update rules to prevent prettier to run #475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
webpack-loader
runs prettier in development mode. This is the current default. With the updated version of Prettier from 2 to 3, the trailing comma setting changed to all. Unfortunately, thevue-loader
chokes on the additional commas and refuses to build the Vue files.This PR will disable the prettify step during the Vue build for the development build. Thus no issue is triggered for the build with the Vue loader.
This is more of a central fix to prevent others to run into the same issue as me and needing to configure the rules locally in the apps. This is only intended as a temporary workaround until the vue loader can handle the extra commas. As the default codebase would ideally be prettified already, the impact on readability should not be too much.