Skip to content

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 6, 2025

☑️ Resolves

  • Fix [Meta] Forms design improvement #7124
  • Added description for the NcAppSettingsSection
  • Adjusted to the new design
    • To be used with NcFormGroup and NcFormBox components
  • Added legacy prop to revert breaking parts of the new design
  • ⚠️ Documentation improvement is in progress
    • Please do not review the documentation update
    • PR will be merged as it is, and the documentation will be adjusted later

🖼️ Screenshots

With legacy design

🏚️ Before 🏡 After
image image

With the new design

image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added this to the 9.2.0 milestone Nov 6, 2025
@ShGKme ShGKme self-assigned this Nov 6, 2025
@ShGKme ShGKme added enhancement New feature or request 3. to review Waiting for reviews labels Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.60%. Comparing base (e3aa13c) to head (0f78429).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7797      +/-   ##
==========================================
+ Coverage   51.57%   51.60%   +0.03%     
==========================================
  Files          96       96              
  Lines        3143     3145       +2     
  Branches      864      863       -1     
==========================================
+ Hits         1621     1623       +2     
  Misses       1274     1274              
  Partials      248      248              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements / visual polishing 🎉

@susnux susnux merged commit 1128a09 into main Nov 6, 2025
27 checks passed
@susnux susnux deleted the feat/NcAppSettingsDialog--new-forms-support branch November 6, 2025 20:51
@susnux
Copy link
Contributor

susnux commented Nov 6, 2025

PR will be merged as it is, and the documentation will be adjusted later

@susnux
Copy link
Contributor

susnux commented Nov 6, 2025

/backport to stable8

@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 6, 2025

PR will be merged as it is, and the documentation will be adjusted later

?

@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 7, 2025

/backport to stable8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Meta] Forms design improvement

4 participants