-
Notifications
You must be signed in to change notification settings - Fork 95
feat(NcAppSettingsDialog): adjust design for new form elements, add section descriptions and optional switch to legacy design #7797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7797 +/- ##
==========================================
+ Coverage 51.57% 51.60% +0.03%
==========================================
Files 96 96
Lines 3143 3145 +2
Branches 864 863 -1
==========================================
+ Hits 1621 1623 +2
Misses 1274 1274
Partials 248 248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AndyScherzinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements / visual polishing 🎉
|
|
/backport to stable8 |
? |
|
/backport to stable8 |
☑️ Resolves
descriptionfor theNcAppSettingsSectionNcFormGroupandNcFormBoxcomponentslegacyprop to revert breaking parts of the new design🖼️ Screenshots
With legacy design
With the new design
🏁 Checklist
stable8for maintained Vue 2 version or not applicable