feat(NcRadioGroup): add component to group radio buttons #7441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
Contributor
Author
|
Adjusted the label a bit, I think this is a quite solid base for that feature. But for now it should already work as intended. |
kra-mo
approved these changes
Sep 4, 2025
Member
kra-mo
left a comment
kra-mo
left a comment
There was a problem hiding this comment.
I was gonna write a bit about how this would all fit together with the other component changes, but it's honestly not all that relevant to this specific PR.
As it stands, it looks nice from a design POV, approved :)
Still, could we have a conversation about the specific changes being made across components atm? Because I feel like I don't have a clear overview.
This comment was marked as resolved.
This comment was marked as resolved.
susnux
force-pushed
the
feat/radio-group
branch
from
53bf045 to
1697d7d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
susnux
force-pushed
the
feat/radio-group
branch
from
1697d7d to
0856d0e
Compare
susnux
force-pushed
the
feat/radio-group
branch
from
a67c36b to
da539b2
Compare
This allows to only add the model value on the wrapper and the radio buttons automatically update it. Also it has a nicer implementation of the button variant. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/radio-group
branch
from
da539b2 to
a211b72
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/radio-group
branch
from
a211b72 to
2cc4985
Compare
Contributor
Author
|
/backport to stable8 |
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
<NcRadioGroup>+<NcCheckboxGroup>components #7121This allows to only add the model value on the wrapper and the radio buttons automatically update it.
Also it has a nicer implementation of the button variant.
🖼️ Screenshots
🚧 Tasks
🏁 Checklist
stable8for maintained Vue 2 version or not applicable