[stable8] feat: add NcKbd component #7407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
added
enhancement
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
backport/7401/stable8
branch
from
f39f3c8 to
1a08b28
Compare
ShGKme
approved these changes
Sep 1, 2025
Antreesy
approved these changes
Sep 1, 2025
| Escape: !props.mac | ||
| ? t('Escape') // TRANSLATORS: Escape key on keyboard | ||
| : '⎋', | ||
| Space: t('Space'), // TRANSLATORS: Space key on keyboard |
Contributor
There was a problem hiding this comment.
Is comma here not a problem? I remember we just discussed it
Contributor
There was a problem hiding this comment.
No, only being the third operand here is a problem.
See updated translations.
susnux
approved these changes
Sep 1, 2025
susnux
reviewed
Sep 1, 2025
webpack.config.js
Outdated
| sassOptions: { | ||
| sourceMapContents: false, | ||
| loadPaths: [ | ||
| includePaths: [ |
Contributor
There was a problem hiding this comment.
This breaks netlifiy as the stylesheets can no longer be found
Contributor
There was a problem hiding this comment.
Works locally and on main...
Contributor
There was a problem hiding this comment.
Ok, on the main loader is outdated
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
backport/7401/stable8
branch
from
1a08b28 to
e3b0744
Compare
susnux
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7401
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.