Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Aug 18, 2025

☑️ Resolves

On v9 this is fixed as all containers already have box-sizing: boder-box but on v8 we need to manually ensure this.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

On v9 this is fixed as all containers already have
`box-sizing: boder-box` but on v8 we need to manually ensure this.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the 8.29.1 milestone Aug 18, 2025
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: checkbox-radio-switch Related to the checkbox-radio-switch component labels Aug 18, 2025
@susnux susnux linked an issue Aug 18, 2025 that may be closed by this pull request
@ShGKme
Copy link
Contributor

ShGKme commented Aug 19, 2025

We have many components without explicit box-sizing: boder-box. Maybe add it to all the components (except for large containers like modal, where we considered it a breaking change)?

@susnux
Copy link
Contributor Author

susnux commented Aug 19, 2025

Maybe add it to all the components (except for large containers like modal, where we considered it a breaking change)?

Makes sense but sounds like much work to adjust all components?

@susnux susnux merged commit 1905b34 into stable8 Aug 19, 2025
17 of 19 checks passed
@susnux susnux deleted the fix/nc-checkbox-box-sizing branch August 19, 2025 12:57
@ShGKme
Copy link
Contributor

ShGKme commented Aug 19, 2025

Makes sense but sounds like much work to adjust all components?

Waiting for an issue from every single component used outside the container, debugging again, and fixing box-sizing doing it one by one also doesn't sound like a small work to me

@susnux susnux mentioned this pull request Aug 19, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: checkbox-radio-switch Related to the checkbox-radio-switch component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NcCheckboxRadioSwitch wrong box-sizing

5 participants