Skip to content

fix(NcAvatar): keep line-height only for 'initials' avatars #6669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

fix(NcAvatar): keep line-height only for 'initials' avatars #6669

merged 1 commit into from
Apr 1, 2025

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 31, 2025

☑️ Resolves

  • Fix unnecessary scrolling, if NcAvatar is in the list
    • There might be an invisible symbol rendered, which causes DOM element to be larger than its actual size
    • If there is no image, but only initials - line-height centers them in the circle, and scroll-height is correct

🖼️ Screenshots

🏚️ Before 🏡 After
2025-03-31_19h30_49 2025-03-31_19h30_28

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy
fix(NcAvatar): keep line-height only for 'initials' avatars
f7626d2 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: avatar Related to the avatar component labels Mar 31, 2025
@Antreesy Antreesy added this to the 8.24.0 milestone Mar 31, 2025
@Antreesy Antreesy requested review from ShGKme and susnux March 31, 2025 17:35
@Antreesy Antreesy self-assigned this Mar 31, 2025
@Antreesy
Copy link
Contributor Author

Antreesy commented Mar 31, 2025

/backport to next

susnux
susnux reviewed Mar 31, 2025
View reviewed changes
@susnux susnux requested a review from DorraJaouad April 1, 2025 17:21
@Antreesy Antreesy merged commit e1248ae into master Apr 1, 2025
23 checks passed
@Antreesy Antreesy deleted the fix/noid/avatar-scroll-height branch April 1, 2025 17:54
@backportbot backportbot bot mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels

3. to review Waiting for reviews bug Something isn't working feature: avatar Related to the avatar component

Projects

None yet

Milestone

8.24.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Antreesy @susnux @DorraJaouad