Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NcAppContent): add no-split layout + feat(NcListItem): add one-line layout #5209

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Feb 2, 2024

☑️ Resolves

Having the possibility to switch to a full-width message/thread list. The three column design (nav + list + content) becomes two columns: nav + list or nav + content. The user will see the list. When they navigate to a message/thread, the content shows.

Adding a prop layoutMode to switch between views on NcAppContent and changing a bit the NcListItem, instead of putting the details inside the "line one" / "line two" we should split main content and details.

This allows to switch from flex-direction column to row for one-line layout without adjusting the DOM. This way we have the possibility to show the list in one line on mail, without breaking the other apps.

When we are on list mode(oneLine) and content view is shown(aka thread on mail), we need to have both button, the back button and the navigation button. So, we had to change a bit how to show that on content view. We will need a better solution for those 2 buttons in the future, but for now it works apart from some edge cases.

🖼️ Screenshots

After
Screenshot from 2024-03-07 08-56-35

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@GretaD GretaD added the 2. developing Work in progress label Feb 2, 2024
@GretaD GretaD self-assigned this Feb 2, 2024
@GretaD GretaD added the enhancement New feature or request label Feb 2, 2024
@GretaD GretaD force-pushed the feat/full-width-mail branch from a5d74d3 to 0a29f35 Compare February 12, 2024 14:22
@GretaD GretaD requested a review from susnux February 12, 2024 18:59
@GretaD GretaD force-pushed the feat/full-width-mail branch from 3558b55 to 33b46e5 Compare February 13, 2024 21:38
@GretaD
Copy link
Contributor Author

GretaD commented Feb 13, 2024

A comment from Ferdinand:

Currently we have:
line one
content | details
line two
content | details
but it would be easier to have
content | details
with content:
content one
content two
And same with the details..

@susnux
Copy link
Contributor

susnux commented Feb 14, 2024

A comment from Ferdinand

Yes instead of putting the details inside the "line one" / "line two" we should split main content and details.
This allows to switch from flex-direction collumn to row for one-line layout without adjusting the DOM.

We only need to change the styles then.

@ShGKme ShGKme modified the milestones: 8.8.2, 8.9.0 Feb 29, 2024
@ChristophWurst ChristophWurst changed the title Add a new slot to support full width view for mail list feat(NcAppContent): Support full width lists Mar 4, 2024
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 6, 2024
@st3iny st3iny requested review from skjnldsv and ShGKme March 6, 2024 11:25
@st3iny st3iny marked this pull request as ready for review March 6, 2024 11:26
Copy link
Contributor

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this for regressions on Spreed and Calendar and it worked fine.

@juliusknorr juliusknorr modified the milestones: 8.9.0, 8.10.0 Mar 6, 2024
@GretaD GretaD added feature: app-content Related to the app-content component feature: list-item Related to the list-item component labels Mar 7, 2024
@GretaD GretaD force-pushed the feat/full-width-mail branch 4 times, most recently from ce12001 to 362d30f Compare March 7, 2024 13:21
@GretaD GretaD requested a review from ShGKme March 7, 2024 13:29
src/components/NcAppContent/NcAppContent.vue Outdated Show resolved Hide resolved
src/components/NcAppContent/NcAppContent.vue Outdated Show resolved Hide resolved
src/components/NcListItem/NcListItem.vue Outdated Show resolved Hide resolved
src/components/NcListItem/NcListItem.vue Outdated Show resolved Hide resolved
src/components/NcListItem/NcListItem.vue Outdated Show resolved Hide resolved
src/components/NcListItem/NcListItem.vue Outdated Show resolved Hide resolved
@GretaD GretaD requested a review from ShGKme March 7, 2024 14:14
@GretaD GretaD requested a review from ShGKme March 7, 2024 16:23
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to work fine, thanks for changes 😊

Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD force-pushed the feat/full-width-mail branch from cd89714 to 6f74155 Compare March 7, 2024 18:05
@ShGKme ShGKme requested a review from ChristophWurst March 7, 2024 18:55
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. No changes for an app that doesn't change 👍 🙏
  2. Works with Add the possibility to change mail list view into full width nextcloud/mail#9285 and a few minor adjustments 👍

@ChristophWurst ChristophWurst merged commit 61da1b3 into master Mar 7, 2024
18 checks passed
@ChristophWurst ChristophWurst deleted the feat/full-width-mail branch March 7, 2024 18:58
@ShGKme ShGKme changed the title feat(NcAppContent): Support full width lists feat(NcAppContent): add no-split layout + feat(NcListItem): add one-line layout Mar 7, 2024
@ShGKme
Copy link
Contributor

ShGKme commented Mar 8, 2024

/backport to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: app-content Related to the app-content component feature: list-item Related to the list-item component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants