-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NcAppContent): add no-split layout + feat(NcListItem): add one-line layout #5209
Conversation
a5d74d3
to
0a29f35
Compare
3558b55
to
33b46e5
Compare
A comment from Ferdinand: Currently we have: |
Yes instead of putting the details inside the "line one" / "line two" we should split main content and details. We only need to change the styles then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this for regressions on Spreed and Calendar and it worked fine.
ce12001
to
362d30f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to work fine, thanks for changes 😊
Signed-off-by: greta <gretadoci@gmail.com>
cd89714
to
6f74155
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- No changes for an app that doesn't change 👍 🙏
- Works with Add the possibility to change mail list view into full width nextcloud/mail#9285 and a few minor adjustments 👍
/backport to next |
☑️ Resolves
Having the possibility to switch to a full-width message/thread list. The three column design (nav + list + content) becomes two columns: nav + list or nav + content. The user will see the list. When they navigate to a message/thread, the content shows.
Adding a prop layoutMode to switch between views on NcAppContent and changing a bit the NcListItem, instead of putting the details inside the "line one" / "line two" we should split main content and details.
This allows to switch from flex-direction column to row for one-line layout without adjusting the DOM. This way we have the possibility to show the list in one line on mail, without breaking the other apps.
When we are on list mode(oneLine) and content view is shown(aka thread on mail), we need to have both button, the back button and the navigation button. So, we had to change a bit how to show that on content view. We will need a better solution for those 2 buttons in the future, but for now it works apart from some edge cases.
🖼️ Screenshots
After
🚧 Tasks
🏁 Checklist