Scope global #content styles via extra class #3537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
added
bug
szaimen
reviewed
Dec 2, 2022
st3iny
force-pushed
the
fix/3534/guest-content-unscoped-content
branch
from
956b978 to
d8108cd
Compare
ChristophWurst
approved these changes
Dec 2, 2022
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
fix/3534/guest-content-unscoped-content
branch
from
d8108cd to
49c1003
Compare
ChristophWurst
approved these changes
Dec 2, 2022
nickvergessen
approved these changes
Dec 2, 2022
Pytal
approved these changes
Dec 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3534
I also improved the documentation of
NcGuestContentto clarify its usages and caveats.Unrelated sites
Observe the bottom margin that was incorrectly applied to all pages before. Now, it's only applied when
NcGuestContentis actually used.NcGuestContentsample usage from calendar appointmentsThe global styling still works with my patch applied. Otherwise, there would be weird margin between the bottom and the scrollable area.
nc-guest-content-after.webm