Skip to content

Commit 4cb4be6

Browse files
susnuxbackportbot[bot]
authored andcommitted
fix(NcAppSidebar): remove slot styling for buttons in the description
1. this probably was meant to center some icons within the button (22px sounds like it was the legacy 44px clickable area / 2). 2. but this breaks usage of any component within that slot. Users of the component should rather self implement padding for their custom buttons if they need them Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
1 parent 9754c34 commit 4cb4be6

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

src/components/NcAppSidebar/NcAppSidebar.vue

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1574,17 +1574,3 @@ $top-buttons-spacing: $app-navigation-padding; // align with app navigation
15741574
margin-inline-end: calc(-1 * var(--app-sidebar-width));
15751575
}
15761576
</style>
1577-
1578-
<style lang="scss">
1579-
// ! slots specific designs, cannot be scoped
1580-
// if any button inside the description slot, increase visual padding
1581-
.app-sidebar-header__description {
1582-
button, .button,
1583-
input[type='button'],
1584-
input[type='submit'],
1585-
input[type='reset'] {
1586-
padding: 6px 22px;
1587-
}
1588-
}
1589-
1590-
</style>

0 commit comments

Comments
 (0)