Skip to content

Commit 465252c

Browse files
authored
Merge pull request #6706 from nextcloud-libraries/fix/NcActions--onOpen-is-not-defined
fix(NcActions): trigger forgotten closed event and correctly handle open
2 parents d461886 + 9b7d21a commit 465252c

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

src/components/NcActions/NcActions.vue

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1369,6 +1369,15 @@ export default {
13691369
})
13701370
},
13711371
1372+
onClosed() {
1373+
/**
1374+
* Event emitted when the popover menu is closed.
1375+
*
1376+
* This event is emitted after `update:open` was emitted and the closing transition finished.
1377+
*/
1378+
this.$emit('closed')
1379+
},
1380+
13721381
/**
13731382
* Handle resizing the popover to make sure users can discover there is more to scroll
13741383
*/
@@ -1760,7 +1769,8 @@ export default {
17601769
setReturnFocus: this.config.withFocusTrap ? this.$refs.triggerButton?.$el : null,
17611770
focusTrap: this.config.withFocusTrap,
17621771
onShow: this.openMenu,
1763-
onApplyShow: this.onOpen,
1772+
onAfterShow: this.onOpened,
1773+
onAfterClose: this.onClosed,
17641774
onHide: this.closeMenu,
17651775
},
17661776
{

0 commit comments

Comments
 (0)