Skip to content

Commit 2c18a32

Browse files
committed
fixup! fixup! fix(NcRadioGroup): fieldsets always need a label for accessibility
1 parent b0e5e03 commit 2c18a32

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

src/components/NcRadioGroup/NcRadioGroup.vue

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@
66
<script setup lang="ts">
77
import type { Slot } from 'vue'
88
9-
import { computed, provide, ref, warn, watchEffect } from 'vue'
9+
import { computed, provide, ref, warn } from 'vue'
1010
import { createElementId } from '../../utils/createElementId.ts'
1111
import { INSIDE_RADIO_GROUP_KEY } from './useNcRadioGroup.ts'
1212
1313
const modelValue = defineModel<string>({ required: false, default: '' })
1414
15-
const props = defineProps<{
15+
defineProps<{
1616
/**
1717
* Label of the radio group (accessible name).
1818
* It can be hidden visually if needed using `hidden-label` prop.
@@ -49,12 +49,6 @@ provide(INSIDE_RADIO_GROUP_KEY, computed(() => ({
4949
onUpdate,
5050
})))
5151
52-
watchEffect(() => {
53-
if (!props.label) {
54-
warn('[NcRadioGroup] For accessibility reasons a proper "label" has to be set.')
55-
}
56-
})
57-
5852
/**
5953
* Register a child component
6054
*

0 commit comments

Comments
 (0)