Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust generateFilePath to include type also for index.php #566

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 25, 2024

It seemed to me wrong that generateFilePath('app', 'type 'index.php') would ignore the type, currently it returns '/index.php/apps/app/' where I would expect '/index.php/apps/app/type'.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review labels Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (571c42f) 97.28% compared to head (b47d7fc) 97.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
- Coverage   97.28%   97.27%   -0.02%     
==========================================
  Files           1        1              
  Lines         221      220       -1     
  Branches       33       33              
==========================================
- Hits          215      214       -1     
  Misses          5        5              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@susnux susnux merged commit 3f8327e into master Jan 29, 2024
15 checks passed
@susnux susnux deleted the fix/generate-filepath-type branch January 29, 2024 11:30
@Antreesy Antreesy mentioned this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants