Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpOptions missing on OAuth config in experimental version #8491

Open
patrickpilch opened this issue Sep 4, 2023 · 12 comments
Open

httpOptions missing on OAuth config in experimental version #8491

patrickpilch opened this issue Sep 4, 2023 · 12 comments
Labels
core Refers to `@auth/core` enhancement New feature or request help-needed The maintainer needs help due to time constraint/missing knowledge

Comments

@patrickpilch
Copy link

Description 📓

We have been using the httpOptions parameter in next-auth's 4.x OAuthConfig to set a header we require for our IDP.

I noticed this is missing in @auth/core's OAuth2Config, and unfortunately will be a blocker/headache for us to upgrade.

It seems the 'oauth4webapi' library supports additional headers.

How to reproduce ☕️

N/A

Contributing 🙌🏽

Yes, I am willing to help implement this feature in a PR

@patrickpilch patrickpilch added enhancement New feature or request triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. labels Sep 4, 2023
@balazsorban44
Copy link
Member

balazsorban44 commented Sep 4, 2023

Can you add a more concrete example? N/A is not a valid reproduction. 🤷‍♂️ Even if it's a feature request, it would be good to understand the reason.

@balazsorban44 balazsorban44 added incomplete Insufficient reproduction. Without more info, we won't take further actions/provide help. and removed incomplete Insufficient reproduction. Without more info, we won't take further actions/provide help. labels Sep 4, 2023
@github-actions github-actions bot added the incomplete Insufficient reproduction. Without more info, we won't take further actions/provide help. label Sep 4, 2023
@nextauthjs nextauthjs deleted a comment from github-actions bot Sep 4, 2023
@patrickpilch
Copy link
Author

Usage on 4.x

Keycloak({ 
  // ...
  httpOptions: {
    headers: {
      'some-header-name': 'some-header-value'
    }
  }
}),

Usage on 5.x
Not possible. The config type is missing the httpOptions parameter, or something similar.

As for the reasoning and use-case: there could be all sorts. One concrete example for custom header support would be if the authorization server is behind a security proxy and requires a service token or other authorization header(s). Of course there are other ways of addressing this scenario with varying levels of complexity, but using headers was a very simple & effective way to get going. Let me know if there's anything else I can provide.

@balazsorban44 balazsorban44 removed the incomplete Insufficient reproduction. Without more info, we won't take further actions/provide help. label Sep 5, 2023
@mikekellyio
Copy link

This is a blocker for my app and v5 as well. Another use case, setting a custom agent in httpOptions

httpOptions: {
  agent: new https.Agent({
    cert: /* cert */,
    key: /* key */
  })
}

@PaulWild
Copy link

This will be a blocker for us as well unfortunately from upgrading - our use case is similar in that we require additional httpHeaders on the requests made to our OAuth provider

@balazsorban44 balazsorban44 removed the triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. label Jan 23, 2024
@balazsorban44
Copy link
Member

oauth4webapi recently added https://github.com/panva/oauth4webapi/blob/main/docs/variables/experimental_customFetch.md which might be useful, we will revisit!

@balazsorban44 balazsorban44 added the core Refers to `@auth/core` label Jan 23, 2024
@bujikun
Copy link

bujikun commented Feb 1, 2024

I am facing this similar issue. I can not extend the timeout during debugging.
I had this in v4, after upgrading to v5, i can no longer do the same.
httpOptions: { timeout:15000 },

Can we please have this back? Or another way of doing this?

@leog
Copy link

leog commented Mar 3, 2024

same as @bujikun, missing the timeoutoption

@finley0066
Copy link

same as @bujikun , missing the timeout and agent options
httpOptions: {
timeout: 30000,
agent: proxyAgent
}

@MarcieMarc425
Copy link

Update on this? Would love to use next auth v5, but without the config for agent in http options, this is currently blocking

@ThangHuuVu ThangHuuVu added the help-needed The maintainer needs help due to time constraint/missing knowledge label Aug 24, 2024
Copy link

This issue was marked with the help needed label by a maintainer.

The issue might require some digging, so it is recommended to have some experience with the project.

Have a look at the Contributing Guide first.

This will help you set up your development environment to get started. When you are ready, open a PR, and link back to this issue in the form of adding Fixes #1234 to the PR description, where 1234 is the issue number. This will auto-close the issue when the PR gets merged, making it easier for us to keep track of what has been fixed.

Please make sure that - if applicable - you add tests for the changes you make.

If you have any questions, feel free to ask in the comments below or the PR. Generally, you don't need to @mention anyone directly, as we will get notified anyway and will respond as soon as we can)

Note

There is no need to ask for permission "can I work on this?" Please, go ahead if there is no linked PR 🙂

@PaulWild
Copy link

PaulWild commented Oct 8, 2024

Is this closed by #11975?

@chrisvalentine
Copy link

Is this closed by #11975?

Happen to have an example of how you'd use customFetch for this particular issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` enhancement New feature or request help-needed The maintainer needs help due to time constraint/missing knowledge
Projects
None yet
Development

No branches or pull requests

10 participants