Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing env variable in OIDC configurations that require issuer #11802

Closed
edelagnier opened this issue Sep 10, 2024 · 3 comments · Fixed by #11976
Closed

Missing env variable in OIDC configurations that require issuer #11802

edelagnier opened this issue Sep 10, 2024 · 3 comments · Fixed by #11976
Labels
docs Relates to documentation good first issue Good issue to take for first time contributors

Comments

@edelagnier
Copy link

edelagnier commented Sep 10, 2024

What is the improvement or update you wish to see?

When following the getting started guide and selecting keycloak, there is no mention of the "AUTH_KEYCLOAK_ISSUER" variable

image

It will result in the following error "[auth][error] InvalidEndpoints: Provider "keycloak" is missing both issuer and authorization endpoint config."

The information is correct in the dedicated keycloak page
image

Is there any context that might help us understand?

none

Does the docs page already exist? Please link to it.

No response

@edelagnier edelagnier added docs Relates to documentation triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. labels Sep 10, 2024
@balazsorban44
Copy link
Member

balazsorban44 commented Sep 25, 2024

This is not unique to Keycloak. See my comment: #11848 (comment)

Essentially, any self-hosted/instantiated OIDC provider needs this.

@balazsorban44 balazsorban44 changed the title Missing env variable in Keycloak configuration Missing env variable in OIDC configurations that require issuer Sep 25, 2024
@balazsorban44 balazsorban44 added good first issue Good issue to take for first time contributors and removed triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. labels Sep 25, 2024
Copy link

This issue was marked with the good first issue label by a maintainer.

This means that it is a good candidate for someone interested in contributing to the project, but does not know where to start.

Have a look at the Contributing Guide first.

This will help you set up your development environment to get started. When you are ready, open a PR, and link back to this issue in the form of adding Fixes #1234 to the PR description, where 1234 is the issue number. This will auto-close the issue when the PR gets merged, making it easier for us to keep track of what has been fixed.

Please make sure that - if applicable - you add tests for the changes you make.

If you have any questions, feel free to ask in the comments below or the PR. Generally, you don't need to @mention anyone directly, as we will get notified anyway and will respond as soon as we can)

Note

There is no need to ask for permission "can I work on this?" Please, go ahead if there is no linked PR 🙂

@DevRish
Copy link
Contributor

DevRish commented Oct 5, 2024

@balazsorban44 I went through the provider documentation pages and listed the ones requiring _ISSUER env variable.

These are the ones I found:

  • authentik
  • azure-ad-b2c
  • battlenet
  • beyondidentity
  • boxyhq-saml
  • cognito
  • descope
  • duende-identityserver-6
  • fusionauth
  • identity-server4
  • keycloak
  • mastodon
  • mattermost
  • okta
  • osso
  • passage

I added a field to the manifest.json file to contain this list, and implemented the displaying of the additional env variable for them.

Please let me know if I missed any providers or wrongly included any of them. Also, please review my PR #11976 .

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Relates to documentation good first issue Good issue to take for first time contributors
Projects
None yet
3 participants