Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official providers All provider's logo is not proper showing #10327

Open
kr-nikunj opened this issue Mar 15, 2024 · 10 comments
Open

Official providers All provider's logo is not proper showing #10327

kr-nikunj opened this issue Mar 15, 2024 · 10 comments
Labels
docs Relates to documentation good first issue Good issue to take for first time contributors

Comments

@kr-nikunj
Copy link

What is the improvement or update you wish to see?

According to the mode of the site, logo colors should change. If dark mode is enabled then the logo should be white and the same for the opposite.

image

some logos are not loaded properly

image

Is there any context that might help us understand?

No

Does the docs page already exist? Please link to it.

https://authjs.dev/getting-started/providers

@kr-nikunj kr-nikunj added docs Relates to documentation triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. labels Mar 15, 2024
@balazsorban44 balazsorban44 added good first issue Good issue to take for first time contributors and removed triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. labels Apr 8, 2024
Copy link

github-actions bot commented Apr 8, 2024

This issue was marked with the good first issue label by a maintainer.

This means that it is a good candidate for someone interested in contributing to the project, but does not know where to start.

Have a look at the Contributing Guide first.

This will help you set up your development environment to get started. When you are ready, open a PR, and link back to this issue in the form of adding Fixes #1234 to the PR description, where 1234 is the issue number. This will auto-close the issue when the PR gets merged, making it easier for us to keep track of what has been fixed.

Please make sure that - if applicable - you add tests for the changes you make.

If you have any questions, feel free to ask in the comments below or the PR. Generally, you don't need to @mention anyone directly, as we will get notified anyway and will respond as soon as we can)

Note

There is no need to ask for permission "can I work on this?" Please, go ahead if there is no linked PR 🙂

@Farooq-Abdulla
Copy link

is this issue still open ? if yes , how do i get to this file?

@srpiroliro
Copy link

is this issue still open ? if yes , how do i get to this file?

For now, the only thing I found is that the images are hosted on authjs.dev site (https://authjs.dev/img/providers/...), and https://authjs.dev/img/providers/google.svg gives the Google icon.
About the dark style logos, no idea.

All of this was found inside of /node_modules/@auth/core/lib/pages/signin.js

@Bisxsh
Copy link

Bisxsh commented Jun 22, 2024

Dark style logos were removed in #10542 as they were sparsely used anyway, so the dark mode part of this issue is probably redundant now
Haven't looked into the logo loading problem so can't speak on that

@Jay-Karia
Copy link
Contributor

image

I think the page got updated and this issue should be closed

@mabbasbangash97
Copy link

https://authjs.dev/getting-started/providers

The github and okta logos are still not resembling the theme.

@Jay-Karia
Copy link
Contributor

Jay-Karia commented Jul 24, 2024

Oh my bad 🙃,
This is the file where the logos are rendered.
And here are the logo files.

So updating the logo file might fix this!

@Jay-Karia
Copy link
Contributor

Dark style logos were removed in #10542 as they were sparsely used anyway, so the dark mode part of this issue is probably redundant now Haven't looked into the logo loading problem so can't speak on that

@Bisxsh They have removed dark styled logos from the application, not from the docs (which is referred in this issue)

@Saichandra2520
Copy link

I'm currently working on this issue and will submit a pull request soon.

@definitelynotchirag

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Relates to documentation good first issue Good issue to take for first time contributors
Projects
None yet
Development

No branches or pull requests

9 participants