Skip to content

Conversation

@ceckoslab
Copy link
Contributor

Because we have "store_id" in ESI data we don't need to pass:

$esiData->setDesignPackage( Mage::getDesign()->getPackageName() );
$esiData->setDesignTheme( Mage::getDesign()->getTheme( 'layout' ) );

In Nexcessnet_Turpentine_EsiController we have:

Mage::app()->setCurrentStore(Mage::app()->getStore( $esiData->getStoreId() ) );

this is the reason why we don't need:

Mage::getSingleton( 'core/design_package' )
  ->setPackageName( $esiData->getDesignPackage() )
  ->setTheme( $esiData->getDesignTheme() );

Because in this case Magento knows "store_id" then correct design package, skin path, layout path and etc. will be taken from configuration for this "store_id" ... no need those values to be passed through ESI data.

@miguelbalparda miguelbalparda self-assigned this Oct 9, 2015
miguelbalparda added a commit that referenced this pull request Oct 9, 2015
#971 - Fixed bug with wrong return value of ->getSkinUrl() in ESI con…
@miguelbalparda miguelbalparda merged commit 5d88c74 into nexcess:devel Oct 9, 2015
@miguelbalparda
Copy link
Contributor

Thank you for your contribution @ceckoslab!

@cscd98
Copy link
Contributor

cscd98 commented Feb 24, 2016

@miguelbalparda @ceckoslab This has completely broken the ability to set a custom theme for CMS pages in magento admin. Please revert this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants