This repository has been archived by the owner on Mar 29, 2024. It is now read-only.
Adds README #25
Merged
Adds README #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamBurdett
approved these changes
Mar 29, 2019
lukeorland
reviewed
Apr 1, 2019
| @@ -24,5 +24,6 @@ def to_excel(df: pd.DataFrame, file_path: str, engine='', **kwargs) -> None: | |||
| with open(tmp_file, 'rb') as source, s3.open(file_path, 'wb') as dest: | |||
| dest.write(source.read()) | |||
| os.remove(tmp_file) | |||
| return | |||
There was a problem hiding this comment.
This isn't required here. it was before when the next line was an outdented df.to_excel(writer, **kwargs), which leads me to ask,
What should this function do in the case that is_s3_path(file_path) != True?
There was a problem hiding this comment.
It should just run plain vanilla pandas.to_excel.
The reason this was added was because both versions were running and causing downstream code to fail in the process since vanilla pandas has no concept of an s3 key
There was a problem hiding this comment.
oh, oops, I see that happens below. The GitHub view is difficult for me to read sometimes. 👍
lukeorland
reviewed
Apr 1, 2019
| ``` | ||
| ## Excel | ||
|
|
||
| By default, pandas will natively read to s3 but won't write to s3. |
lukeorland
reviewed
Apr 1, 2019
|
|
||
| By default, pandas will natively read to s3 but won't write to s3. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is