Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build semver checking into instrumentation registration #2501

Open
kmudduluru opened this issue Aug 20, 2024 · 1 comment
Open

Build semver checking into instrumentation registration #2501

kmudduluru opened this issue Aug 20, 2024 · 1 comment
Labels
points: 5 1-2 weeks

Comments

@kmudduluru
Copy link
Contributor

kmudduluru commented Aug 20, 2024

Description

Is your feature request related to a problem? Please describe.
There have been a few times we have to add semver checks before registering something or have forked logic to determine what to do for a given module. We could cut down on fragmented version checks by building it into both the customer facing API and our internal shim.

Feature Description
allow a semver range to be specified when registering instrumentation in both API and shim.

Additional context
If you search for semver. in agent and external modules we have several use cases. I know this required us to bring semver into the package but also caused some toil with a botched release: https://github.com/newrelic/node-newrelic-aws-sdk/blob/main/index.js

Look into this issue for more details on this ticket - https://new-relic.atlassian.net/browse/NR-133374

@workato-integration
Copy link

@kmudduluru kmudduluru added points: 5 1-2 weeks and removed needs-triage labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
points: 5 1-2 weeks
Projects
Status: Triage Needed: Unprioritized Features
Development

No branches or pull requests

1 participant