Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spike] Update shim to use Proxy instead of assigning a patched function #2499

Open
kmudduluru opened this issue Aug 20, 2024 · 1 comment
Open
Labels
points: 5 1-2 weeks

Comments

@kmudduluru
Copy link
Contributor

Description

Javascript created a standard for wrapping objects Proxy and Reflect(link). Our agent predates these constructs so our shim API saves a reference to a function and re-assigns it. This could cause issues in cases where functions lack a setter. In an effort to stay current with our solutions we should update our patching to instead use Proxy and Reflect when calling constructor.

Notes:
We might be able to just abstract the traps in wrapReturn and re-use everywhere.

Internal ticket for this issue

@workato-integration
Copy link

@kmudduluru kmudduluru added points: 5 1-2 weeks and removed needs-triage labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
points: 5 1-2 weeks
Projects
Status: Triage Needed: Unprioritized Features
Development

No branches or pull requests

1 participant