Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov uploader #2485

Closed
bizob2828 opened this issue Aug 16, 2024 · 2 comments · Fixed by #2490
Closed

Fix codecov uploader #2485

bizob2828 opened this issue Aug 16, 2024 · 2 comments · Fixed by #2490
Assignees
Labels
points: 5 1-2 weeks

Comments

@bizob2828
Copy link
Member

Description

Our codecov job is silently failing and have no idea for how long. I just realized because when reviewing #2481 there was an error during migration and codecov wasn't reporting it. When I looked at the job it shows

gpg: directory '/home/runner/.gnupg' created
gpg: keybox '/home/runner/.gnupg/pubring.kbx' created
gpg: /home/runner/.gnupg/trustdb.gpg: trustdb created
gpg: key 806BB28AED779869: public key "Codecov Uploader (Codecov Uploader Verification Key) <security@codecov.io>" imported
gpg: Total number processed: 1
gpg:               imported: 1
gpg: Signature made Fri Aug 16 16:41:08 2024 UTC
gpg:                using RSA key 27034E7FDB850E0BBC2C62FF806BB28AED779869
gpg: Good signature from "Codecov Uploader (Codecov Uploader Verification Key) <security@codecov.io>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 2703 4E7F DB85 0E0B BC2C  62FF 806B B28A ED77 9869
==> Uploader SHASUM verified (eb902009cb800fdefbce291c1357953f80e29382f43c7a98cce3b57d2b4d8cec  codecov)
==> Running version latest
==> Running version v0.7.4
==> Running git config --global --add safe.directory /home/runner/work/node-newrelic/node-newrelic
/usr/bin/git config --global --add safe.directory /home/runner/work/node-newrelic/node-newrelic
==> Running command '/home/runner/work/_actions/codecov/codecov-action/125fc84a9a348dbcf27[19](https://github.com/newrelic/node-newrelic/actions/runs/10423197970/job/28869826443?pr=2481#step:4:20)1600683ec096ec9021c/dist/codecov create-commit'
/home/runner/work/_actions/codecov/codecov-action/125fc84a9a348dbcf27191600683ec096ec9021c/dist/codecov create-commit --git-service github -C 4defd5aa0ca9b072a88f7819dad57c65399e06a3
info - [20](https://github.com/newrelic/node-newrelic/actions/runs/10423197970/job/28869826443?pr=2481#step:4:21)24-08-16 16:47:46,267 -- ci service found: github-actions
warning - 2024-08-16 16:47:46,274 -- No config file could be found. Ignoring config.
Error: Codecov token not found. Please provide Codecov token with -t flag.
Warning: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/125fc84a9a348dbcf27191600683ec096ec90[21](https://github.com/newrelic/node-newrelic/actions/runs/10423197970/job/28869826443?pr=2481#step:4:22)c/dist/codecov' failed with exit code 1

Acceptance Criteria

codecov upload succeeds, and when fails it will fail CI

@workato-integration
Copy link

@bizob2828
Copy link
Member Author

I think this has to do with posting coverage on PRs from forks. It seems to be working just find on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
points: 5 1-2 weeks
Projects
Archived in project
1 participant