Remove CAT #1489
Open
Remove CAT #1489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1489 +/- ##
==========================================
- Coverage 81.59% 81.49% -0.10%
==========================================
Files 206 206
Lines 23689 23457 -232
Branches 3753 3708 -45
==========================================
- Hits 19328 19117 -211
+ Misses 3100 3088 -12
+ Partials 1261 1252 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hmstepanek
requested changes
Sep 19, 2025
| headers.pop(MessageTrace.cat_id_key, None) | ||
| headers.pop(MessageTrace.cat_transaction_key, None) | ||
| headers.pop(MessageTrace.cat_distributed_trace_key, None) | ||
| headers.pop(MessageTrace.distributed_trace_key, None) |
There was a problem hiding this comment.
Suggested change
| headers.pop(MessageTrace.distributed_trace_key, None) | |
| headers.pop("newrelic", None) |
| user_headers.pop(MessageTrace.cat_id_key, None) | ||
| user_headers.pop(MessageTrace.cat_transaction_key, None) | ||
| user_headers.pop(MessageTrace.cat_distributed_trace_key, None) | ||
| user_headers.pop(MessageTrace.distributed_trace_key, None) |
There was a problem hiding this comment.
Suggested change
| user_headers.pop(MessageTrace.distributed_trace_key, None) | |
| user_headers.pop("newrelic", None) |
| class HeaderMixin: | ||
| synthetics_key = "X-NewRelic-Synthetics" | ||
| synthetics_info_key = "X-NewRelic-Synthetics-Info" | ||
| distributed_trace_key = "newrelic" |
There was a problem hiding this comment.
Suggested change
| distributed_trace_key = "newrelic" |
| _process_setting(section, "debug.connect_span_stream_in_developer_mode", "getboolean", None) | ||
| _process_setting(section, "debug.otlp_content_encoding", "get", None) | ||
| _process_setting(section, "cross_application_tracer.enabled", "getboolean", None) | ||
| # _process_setting(section, "cross_application_tracer.enabled", "getboolean", None) |
There was a problem hiding this comment.
Suggested change
| # _process_setting(section, "cross_application_tracer.enabled", "getboolean", None) |
| intrinsics["error.expected"] = error.expected | ||
| intrinsics["transactionName"] = self.path | ||
| intrinsics["spanId"] = error.span_id | ||
|
|
There was a problem hiding this comment.
Suggested change
| intrinsics["nr.transactionGuid"] = self.guid |
| try: | ||
| dt_headers = MessageTrace.generate_request_headers(transaction) | ||
| if dt_headers: | ||
| headers.update(dict(dt_headers)) |
There was a problem hiding this comment.
Start reviewing again at this file.
TimPansino
force-pushed
the
remove_CAT
branch
from
2001df8 to
f53c517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes Cross Application Tracing (CAT) from the agent