Skip to content

Conversation

@jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Oct 28, 2025

Overview

Resolves #2526

New logback-classic module to support v1.5.20+. The only change was a renamed private method in LoggingEvent_Instrumentation:

extractThrowableAnRearrangeArguments ---> extractThrowableAndRearrangeArguments

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.28%. Comparing base (af29108) to head (c6b8f68).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2535   +/-   ##
=========================================
  Coverage     70.27%   70.28%           
- Complexity    10093    10115   +22     
=========================================
  Files           852      855    +3     
  Lines         41048    41098   +50     
  Branches       6220     6229    +9     
=========================================
+ Hits          28848    28885   +37     
- Misses         9387     9398   +11     
- Partials       2813     2815    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jtduffy jtduffy merged commit 97e7777 into main Oct 30, 2025
221 of 224 checks passed
@jtduffy jtduffy deleted the logback-1.5.20 branch October 30, 2025 12:20
@kmudduluru kmudduluru moved this from Triage to Code Complete/Done in Java Engineering Board Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

New Module: logback-classic for v1.5.20+

4 participants