Skip to content

Conversation

@jbedell-newrelic
Copy link
Contributor

If we detect multiple addresses during the connect cycle for a datastore, in the past we null the address out and pass nothing up. This config allows us to choose what to do: NONE (as we've always done), FIRST or LAST.

This came up when working with Azure SQL from inside of Azure App Services. We appeared to be getting re-directed from the requested host to a 'worker' host and thus we would send up NULL in the server.address field. Setting this to FIRST fixes that problem.

Resolves: #2493

…addresses during datastore detection. Default is NONE (or legacy), with new options of FIRST or LAST.
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.41%. Comparing base (a38449b) to head (1f47c3d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2508      +/-   ##
============================================
- Coverage     70.41%   70.41%   -0.01%     
+ Complexity    10050    10049       -1     
============================================
  Files           845      845              
  Lines         40776    40788      +12     
  Branches       6186     6188       +2     
============================================
+ Hits          28712    28719       +7     
- Misses         9271     9274       +3     
- Partials       2793     2795       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kmudduluru kmudduluru moved this from Triage to Code Complete/Done in Java Engineering Board Oct 7, 2025
@kmudduluru kmudduluru moved this from Code Complete/Done to Needs Review in Java Engineering Board Oct 7, 2025
@jbedell-newrelic jbedell-newrelic merged commit 56fe81b into main Oct 8, 2025
437 of 442 checks passed
@jbedell-newrelic jbedell-newrelic deleted the DatastoreDetectionPreference branch October 8, 2025 16:39
@kmudduluru kmudduluru moved this from Needs Review to Code Complete/Done in Java Engineering Board Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Spike] Investigate the handling of DB redirects inside of Azure App Services

4 participants