Jedis 6 support #2466
Merged
Jedis 6 support #2466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2466 +/- ##
=========================================
Coverage 70.44% 70.44%
+ Complexity 10043 10042 -1
=========================================
Files 845 845
Lines 40730 40730
Branches 6180 6180
=========================================
Hits 28691 28691
+ Misses 9248 9245 -3
- Partials 2791 2794 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jtduffy
reviewed
Aug 25, 2025
...mentation/jedis-6.0.0/src/main/java/redis/clients/jedis/JedisPubSubBase_Instrumentation.java
Outdated
Show resolved
Hide resolved
jtduffy
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2349
This PR bumps the jedis module. It was a very small lift. Starting in version 6.0.0 Jedis wrapped the
Connection clientfield that used to be directly on theJedisPubSubBasewith aJedisSafeAuthenticator, see the diff here.The
clientis a field on the authenticator.I have tested this bumping the AITs to use Jedis 6.0.0. Test run against bumped Jedis AIT: https://github.com/newrelic/newrelic-java-agent/actions/runs/17140747711/job/48628128721