Skip to content

Conversation

@jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Jun 18, 2025

For invalid attributes added to log and events:

  • Now logged at FINEST level rather than WARNING to reduce log spam
  • Key values are now part of the log message. If the key is larger than 3 characters, it's obfuscated -- first character + *** + the last character. For example, MY_LARGER_KEY would print to the log as M***Y

Resolves #2369

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.53%. Comparing base (c446699) to head (8053d79).

Files with missing lines Patch % Lines
...ic/agent/service/logging/LogSenderServiceImpl.java 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2388      +/-   ##
============================================
+ Coverage     70.52%   70.53%   +0.01%     
- Complexity    10035    10039       +4     
============================================
  Files           844      844              
  Lines         40642    40650       +8     
  Branches       6161     6164       +3     
============================================
+ Hits          28661    28673      +12     
  Misses         9198     9198              
+ Partials       2783     2779       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jtduffy jtduffy merged commit 9c38902 into main Jun 18, 2025
257 of 333 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Code Complete/Done in Java Engineering Board Jun 18, 2025
@jtduffy jtduffy deleted the log-invalid-keys branch June 18, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Wrap invalid attribute log messages in a debug flag check

4 participants