Skip to content

Conversation

@nrlkirby
Copy link
Contributor

@nrlkirby nrlkirby commented May 9, 2025

Overview

The existing code to emit KafkaConsumerConfig events, when enabled, has not worked for versions of Kafka 3.7 and onwards. Apache Kafka release versions since then have used a delegation pattern for KafkaConsumer instances, breaking the existing stack-based analysis that the integration applied to confirm that we were only emitting config events attached to actual clients, and not instantiated independently for whatever reason.

Testing

A separately maintained integration test confirmed the existing agent code failed to emit KafkaConsumerConfig events for versions 3.7.0 onwards, as did manual testing. That integration testing confirmed that the agent, with these fixes, produces the expected KafkaConsumerConfig events. Specific versions of kafka-clients tested: 2.6.2, 2.8.1, 3.3.2, 3.4.1, 3.5.0, 3.6.2, 3.7.0, 3.8.0, 3.9.0, 4.0.0. The 3.9.0 and 4.0.0 releases were also tested with and without the consumers configured to use the new async/consumer group protocol that engages a different consumer delegate.

Checks

  • Your contributions are backwards compatible with relevant frameworks and APIs.
  • Your code does not contain any breaking changes. Otherwise please describe.
  • Your code does not introduce any new dependencies. Otherwise please describe.

@CLAassistant
Copy link

CLAassistant commented May 9, 2025

CLA assistant check
All committers have signed the CLA.

@jtduffy
Copy link
Contributor

jtduffy commented May 14, 2025

All tests passed in #2359
Manual tests passed

@jtduffy jtduffy merged commit 763de27 into newrelic:main May 14, 2025
137 of 143 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Code Complete/Done in Java Engineering Board May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants