KafkaConsumerConfig event support for Kafka 3.7+ #2358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The existing code to emit KafkaConsumerConfig events, when enabled, has not worked for versions of Kafka 3.7 and onwards. Apache Kafka release versions since then have used a delegation pattern for KafkaConsumer instances, breaking the existing stack-based analysis that the integration applied to confirm that we were only emitting config events attached to actual clients, and not instantiated independently for whatever reason.
Testing
A separately maintained integration test confirmed the existing agent code failed to emit KafkaConsumerConfig events for versions 3.7.0 onwards, as did manual testing. That integration testing confirmed that the agent, with these fixes, produces the expected KafkaConsumerConfig events. Specific versions of kafka-clients tested: 2.6.2, 2.8.1, 3.3.2, 3.4.1, 3.5.0, 3.6.2, 3.7.0, 3.8.0, 3.9.0, 4.0.0. The 3.9.0 and 4.0.0 releases were also tested with and without the consumers configured to use the new async/consumer group protocol that engages a different consumer delegate.
Checks