Skip to content

Conversation

@jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Apr 23, 2025

Overview

Resolves #2328

Upgrading to snakeyaml 2.4 causes startup failures for Glassfish and Wildfly, related to configuration of their respective loggers.

A drop in replacement for snakeyaml exists - SafeYaml. This is a fork of snakeyaml v1.33 with the security fixes from snakeyaml 2.0 back ported.

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.49%. Comparing base (a0d08e3) to head (129dfee).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2333      +/-   ##
============================================
- Coverage     70.58%   70.49%   -0.09%     
+ Complexity    10042    10023      -19     
============================================
  Files           844      844              
  Lines         40750    40614     -136     
  Branches       6191     6157      -34     
============================================
- Hits          28762    28632     -130     
+ Misses         9210     9194      -16     
- Partials       2778     2788      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jtduffy jtduffy marked this pull request as ready for review April 25, 2025 17:18
@kmudduluru kmudduluru moved this from Triage to Needs Review in Java Engineering Board May 6, 2025
@jtduffy jtduffy merged commit 8c7a0cc into main May 12, 2025
113 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Code Complete/Done in Java Engineering Board May 12, 2025
@jtduffy jtduffy deleted the safeyaml-replacement branch May 12, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Investigate an upgrade to SnakeYaml to v2.0

4 participants