Prevent cache lock for long DB statement parsing #2294
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2262
This change refactors the cache put logic so that on a cache miss, the agent parses the DB statement outside of the put operation (as was done previously) so that parsing very large SQL statements doesn't lock the cache.
Note that this doesn't improve the regex performance against very very large SQL statements; it simply prevents the cache from being locked while the statement is being parsed.