Skip to content

Conversation

@jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Apr 1, 2025

Resolves #2262

This change refactors the cache put logic so that on a cache miss, the agent parses the DB statement outside of the put operation (as was done previously) so that parsing very large SQL statements doesn't lock the cache.

Note that this doesn't improve the regex performance against very very large SQL statements; it simply prevents the cache from being locked while the statement is being parsed.

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.51%. Comparing base (9be91b8) to head (dbf4a39).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2294      +/-   ##
============================================
- Coverage     70.68%   70.51%   -0.18%     
+ Complexity    10355    10029     -326     
============================================
  Files           844      844              
  Lines         41310    40619     -691     
  Branches       6331     6160     -171     
============================================
- Hits          29200    28641     -559     
+ Misses         9283     9193      -90     
+ Partials       2827     2785      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jtduffy jtduffy merged commit 528cfc3 into main Apr 3, 2025
111 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Code Complete/Done in Java Engineering Board Apr 3, 2025
@jtduffy jtduffy deleted the db-parser-optimization branch April 3, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Requests locked on parsing database query

4 participants