nrawssdk-v2: fix usage examples of nrawssdk.AppendMiddlewares

[Meroje]

Links

Details

When testing the nrawssdk-v2 integration along with nrlambda I found out that the provided method of injecting the middleware to APIOptions does not work (no trace is seen for any aws call), what worked was to use the optFns param.

In this PR I'm only changing the documentation and example to reflect what has been working, but maybe you'd want to expand on it to add an exported function that can be used as an optFn ?

Also I could not find how to make the test fail as I'm not familiar enough with the internals.

[CLAassistant]

All committers have signed the CLA.

[iamemilio]

@Meroje Hi, I'm taking a look at this and was wondering what this really changes other than when nrawssdk.AppendMiddlewares(&awsConfig.APIOptions, nil) is invoked. I can see that it's passing the unit test, so I'm not worried about the functionality. I am just not sure why we are changing the usage pattern on users if the outcome is the same.

[Meroje]

I found that the previous method had no effect and I would never get any telemetry from aws sdk.

[iamemilio]

Oh ok, that's a good reason haha. Ok, I'll verify this and see if we can land it in an upcoming release.

[Ak-x]

@Meroje are you able to sign the CLA here so that we can proceed?

[nr-swilloughby]

These changes are approved and we're reviewing what potential changes to the integration may be needed to better support AWS as highlighted by this PR.