-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add license file to v3 and v3/newrelic #254
Conversation
Adds license file to v3/ and v3/newrelic/ subdirectories to make the repository compatible with pkg.go.dev (in particular, https://pkg.go.dev/github.com/google/licensecheck). Resolves #169 #169
@jthurman42 - bringing this to your attention |
I'm not sure why the two integration tests failed?
and
Look to be errors with the versioned aws-sdk libraries? |
Are there any concerns or blockers to merging this issue? I'm unsure how to resolve the AWS SDK build test issues. |
It would be nice to merge this since go pkg docs not showing for v3 https://pkg.go.dev/github.com/newrelic/go-agent/v3/integrations/logcontext/nrlogrusplugin |
Bumping this again - @jthurman42 @jodeev any issues with merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, @tydavis ! Merging to develop
now and releasing soon.
Adds license file to v3/ and v3/newrelic/ subdirectories to make the
repository compatible with pkg.go.dev (in particular,
https://pkg.go.dev/github.com/google/licensecheck).
Resolves #169 #169