Skip to content

Commit 29facb5

Browse files
committed
clean up misc old code with warnings
1 parent a4da6ec commit 29facb5

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

Extensions/audio_plus.js

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,10 @@ XKit.extensions.audio_plus = {
230230
},
231231

232232
create_pop_out_controls: function() {
233-
const controls_markup = `
233+
234+
var psuedo_post = document.createElement("div");
235+
psuedo_post.classList.add("xkit-audio-plus-pseudo-post");
236+
psuedo_post.innerHTML = `
234237
<div class="xkit-audio-plus-controls audio-player">
235238
<div class="progress"></div>
236239
<div class="play-pause">
@@ -245,10 +248,6 @@ XKit.extensions.audio_plus = {
245248
<div id="xkit-audio-plus-controls-undock"></div>
246249
</div>
247250
`;
248-
249-
var psuedo_post = document.createElement("div");
250-
psuedo_post.classList.add("xkit-audio-plus-pseudo-post");
251-
psuedo_post.innerHTML = controls_markup;
252251
document.body.appendChild(psuedo_post);
253252

254253
this.pop_out_controls = psuedo_post;
@@ -384,11 +383,11 @@ XKit.extensions.audio_plus = {
384383
this.icon_observer.observe(pause_icon, config);
385384

386385
if (player.querySelector(".track-name").innerHTML != "") {
387-
this.pop_out_controls_track_name.innerHTML = player.querySelector(".track-name").innerHTML;
386+
this.pop_out_controls_track_name.replaceChildren(player.querySelector(".track-name").cloneNode(true));
388387
} else {
389388
this.pop_out_controls_track_name.innerHTML = "Listen";
390389
}
391-
this.pop_out_controls_track_artist.innerHTML = player.querySelector(".track-artist").innerHTML;
390+
this.pop_out_controls_track_artist.replaceChildren(player.querySelector(".track-artist").cloneNode(true));
392391

393392
this.current_player = player;
394393
this.pop_out_controls.classList.add("showing");

Extensions/old_stats.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ XKit.extensions.old_stats = new Object({
179179
$(".no_push.selected_blog, .no_push.old_stats_blog").last().css("margin", "0 0 18px");
180180

181181
$(".old_stats_blog").click(function() {
182-
$(".no_push.selected_blog .open_blog.with_subtitle")[0].outerHTML = this.firstChild.outerHTML.replace("span", "a");
182+
// $(".no_push.selected_blog .open_blog.with_subtitle")[0].outerHTML = this.firstChild.outerHTML.replace("span", "a");
183183
loading = true;
184184
$("#old_stats_switcher").click();
185185
XKit.extensions.old_stats.fetchStats($(this).find(".currently_selected_blog").html());

0 commit comments

Comments
 (0)