test: fix testing netCDF bbox type file loading from dataset

Author: Sparshr04

movement/napari/loader_widgets.py

@@ -69,9 +69,9 @@ def __init__(self, napari_viewer: Viewer, parent=None):
         self._create_load_button()
 
         # FPS box state
-        self.source_software_combo.currentTextChanged.connect(
-            self._on_source_software_changed
-        )
+        # self.source_software_combo.currentTextChanged.connect(
+        #     self._on_source_software_changed
+        # )
         # To set initial state of the FPS box
         self._on_source_software_changed(
             self.source_software_combo.currentText()
@@ -111,12 +111,17 @@ def _create_fps_widget(self):
         # How much we increment/decrement when the user clicks the arrows
         self.fps_spinbox.setSingleStep(1)
         # Add a tooltip
-        self.fps_spinbox.setToolTip(
+        self.fps_default_tooltip = (
             "Set the frames per second of the tracking data.\n"
             "This just affects the displayed time when hovering over a point\n"
             "(it doesn't set the playback speed)."
         )
-        self.fps_default_tooltip = self.fps_spinbox.toolTip()
+        # self.fps_default_tooltip = self.fps_spinbox.toolTip()
+        self.fps_spinbox.setToolTip(self.fps_default_tooltip)
+        # Connect fps spinbox with _on_source_software_changed
+        self.source_software_combo.currentTextChanged.connect(
+            self._on_source_software_changed,
+        )
         self.layout().addRow("fps:", self.fps_spinbox)
 
     def _create_file_path_widget(self):

tests/test_unit/test_napari_plugin/test_data_loader_widget.py

@@ -256,54 +256,63 @@ def test_on_load_clicked_without_file_path(make_napari_viewer_proxy, capsys):
 
 
 @pytest.mark.parametrize(
-    "filename, source_software, tracks_array_shape",
+    "filename, source_software, tracks_array_shape, is_bbox",
     [
         (
             "VIA_single-crab_MOCA-crab-1.csv",
             "VIA-tracks",
             (35, 4),
+            True,
         ),  # single individual, no keypoints (bboxes)
         (
             "VIA_multiple-crabs_5-frames_labels.csv",
             "VIA-tracks",
             (430, 4),
+            True,
         ),  # multiple individuals, no keypoints (bboxes)
         (
             "SLEAP_single-mouse_EPM.predictions.slp",
             "SLEAP",
             (110910, 4),
+            False,
         ),  # single individual, multiple keypoints
         (
             "DLC_single-wasp.predictions.h5",
             "DeepLabCut",
             (2170, 4),
+            False,
         ),  # single individual, multiple keypoints
         (
             "DLC_two-mice.predictions.csv",
             "DeepLabCut",
             (1439976, 4),
+            False,
         ),  # two individuals, multiple keypoints
         (
             "SLEAP_three-mice_Aeon_mixed-labels.analysis.h5",
             "SLEAP",
             (1803, 4),
+            False,
         ),  # three individuals, one keypoint
         (
             "MOVE_two-mice_octagon.analysis.nc",
             "movement (netCDF)",
             (126000, 4),
+            False,
         ),
         (
             "MOVE_single-crab_MOCA-crab-1_linear-interp.nc",
             "movement (netCDF)",
-            (0, 0),
+            (168, 4),
+            True,
         ),
     ],
 )
 def test_on_load_clicked_with_valid_file_path(
     filename,
     source_software,
     tracks_array_shape,
+    is_bbox,
     make_napari_viewer_proxy,
     caplog,
 ):
@@ -342,7 +351,8 @@ def test_on_load_clicked_with_valid_file_path(
     assert data_loader_widget.data is not None
     assert data_loader_widget.properties is not None
     assert data_loader_widget.data_not_nan is not None
-    if source_software in SUPPORTED_BBOXES_FILES:
+    # if source_software in SUPPORTED_BBOXES_FILES:
+    if is_bbox:
         assert data_loader_widget.data_bboxes is not None
     else:
         # Only bounding boxes datasets should add bboxes data
@@ -379,7 +389,8 @@ def test_on_load_clicked_with_valid_file_path(
         "Added tracked dataset as a napari Points layer.",
         "Added tracked dataset as a napari Tracks layer.",
     }
-    if source_software in SUPPORTED_BBOXES_FILES:
+    # if source_software in SUPPORTED_BBOXES_FILES:
+    if is_bbox:
         expected_log_messages.add(
             "Added tracked dataset as a napari Shapes layer."
         )