-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SparsificationLoggingModifier implementation #1453
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial commit * initial developement * sync with ben * prototype ready * included ben's comments * Update src/sparseml/pytorch/utils/sparsification_info/configs.py Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com> * Update src/sparseml/pytorch/utils/sparsification_info/configs.py Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com> * address comments * fix quantization logic * remove identities from leaf operations * fix the Identity removal * [ModuleSparsificationInfo][Tests] Proposal of the main logic (#1479) * Update src/sparseml/pytorch/utils/sparsification_info/helpers.py Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com> * addressing PR comments --------- Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com>
* initial commit * initial developement * sync with ben * prototype ready * included ben's comments * initial commit * Update src/sparseml/pytorch/utils/sparsification_info/configs.py Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com> * Update src/sparseml/pytorch/utils/sparsification_info/configs.py Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com> * address comments * fix quantization logic * formatting standardised to the PRD * remove identities from leaf operations * fix the Identity removal * initial commit * cleanup * correct tests * address PR comments --------- Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com>
* initial commit * initial developement * sync with ben * prototype ready * included ben's comments * initial commit * Update src/sparseml/pytorch/utils/sparsification_info/configs.py Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com> * Update src/sparseml/pytorch/utils/sparsification_info/configs.py Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com> * address comments * fix quantization logic * formatting standardised to the PRD * remove identities from leaf operations * fix the Identity removal * initial commit * initial commit * checkpoint * Delete modifier_logging.py * Apply suggestions from code review * tested the modifier * Apply suggestions from code review --------- Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com>
dbogunowicz
commented
Mar 28, 2023
dbogunowicz
commented
Mar 28, 2023
dbogunowicz
changed the title
[ModuleSparsificationInfo] Feature Branch
SparsificationLoggingModifier implementation
Mar 28, 2023
corey-nm
approved these changes
Mar 28, 2023
rahul-tuli
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Description
Adds
SparsificationLoggingModifier
. It can be used in the sparsification recipe to periodically log the information about the sparsification properties of the model (e.g. level of pruning, the precision of parameters, etc).Feature Preview
sparseml.image_classification.train --dataset imagenette --arch_key mobilenet --recipe-path recipe.yaml --dataset_path . --train_batch_size 64 --test_batch_size 64
where
recipe.yaml
is:Results in:
Summary
Incorporates the following PRs:
logabble_items
method #1468