Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextGeneration] Fix llama tokenizer (#1635) #1636

Merged
merged 3 commits into from
Mar 18, 2024
Merged

[TextGeneration] Fix llama tokenizer (#1635) #1636

merged 3 commits into from
Mar 18, 2024

Conversation

dhuangnm
Copy link
Member

Pick up Dipika's fix into 1.7

* add llama tokenizer fix

* fix generated string

* only run for streaming

* add TODO

---------

Co-authored-by: Dipika Sikka <dipikasikka1@gmail.coom>
mgoin
mgoin previously approved these changes Mar 14, 2024
dsikka
dsikka previously approved these changes Mar 15, 2024
@dhuangnm dhuangnm dismissed stale reviews from dsikka and mgoin via e1280bc March 15, 2024 15:00
@dhuangnm
Copy link
Member Author

The failure is at the "Install dependencies" step which is trying to pull wand-nightly 1.7.1. Ignoring the failures and force land.

@dhuangnm dhuangnm merged commit 639c9f7 into release/1.7 Mar 18, 2024
0 of 12 checks passed
@dhuangnm dhuangnm deleted the onefix branch March 18, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants