-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StagedTimer
+ TimerManager
Impl + Pipeline.__call__
integration
#1062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall to initially land- two things we need to think through more:
- no clear design for nested pipelines as well as potentially timing bucketing
- eventually need to handle race conditions once we integrate into the server (not worried about server timings since we can call directly into pipeline.inference_timer from the fast api route)
@bfineran didn't we want to make a timer inherit from the |
both work as long as we can split out the timer in scenarios where logger should also be decoupled such as the server. this meets that requirement. |
StagedTimer
+ TimerManager
Impl + Pipeline __call__
integration
StagedTimer
+ TimerManager
Impl + Pipeline __call__
integrationStagedTimer
+ TimerManager
Impl + Pipeline.__call__
integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
adds
StagedTimer
andTimerManager
classes to enable easier benchmarking of pipelines and eventually the end to end deepsparse server flow. See docstring andPipeline.__call__
changes for intended workflow.example usage:
code:
output (after data logs):