This repository was archived by the owner on Jun 3, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
StagedTimer
+ TimerManager
Impl + Pipeline.__call__
integration
#1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfineran
previously approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall to initially land- two things we need to think through more:
- no clear design for nested pipelines as well as potentially timing bucketing
- eventually need to handle race conditions once we integrate into the server (not worried about server timings since we can call directly into pipeline.inference_timer from the fast api route)
dbogunowicz
reviewed
Jun 11, 2023
dbogunowicz
reviewed
Jun 11, 2023
dbogunowicz
reviewed
Jun 11, 2023
dbogunowicz
reviewed
Jun 11, 2023
@bfineran didn't we want to make a timer inherit from the |
both work as long as we can split out the timer in scenarios where logger should also be decoupled such as the server. this meets that requirement. |
bfineran
previously approved these changes
Jun 21, 2023
bfineran
previously approved these changes
Jun 21, 2023
StagedTimer
+ TimerManager
Impl + Pipeline __call__
integration
StagedTimer
+ TimerManager
Impl + Pipeline __call__
integrationStagedTimer
+ TimerManager
Impl + Pipeline.__call__
integration
KSGulin
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
StagedTimer
andTimerManager
classes to enable easier benchmarking of pipelines and eventually the end to end deepsparse server flow. See docstring andPipeline.__call__
changes for intended workflow.example usage:
code:
output (after data logs):