Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose version (automatically) #4

Closed
LeSpocky opened this issue Jan 23, 2024 · 5 comments · Fixed by #5
Closed

Update docker-compose version (automatically) #4

LeSpocky opened this issue Jan 23, 2024 · 5 comments · Fixed by #5

Comments

@LeSpocky
Copy link
Member

Currently in defaults/main.yml there is docker_compose_version: "1.27.4" and that has to be updated once new releases are published. A bot should do that.

@LeSpocky
Copy link
Member Author

While reading through Dependabot tickets I think, that one does not support it:

  1. Support for Docker compose files dependabot/dependabot-core#390
  2. Replace package-ecosystem with specifying both language and package-manager in dependabot.yml dependabot/dependabot-core#7189

We need something else here, at least if we don't wanna wait forever for that feature appearing in Dependabot.

@LeSpocky
Copy link
Member Author

The prominent role we borrow from here does not bump docker_compose_version automatically 🤷🏼‍♂️ .

@penguineer
Copy link
Member

Question is: Do we need the external docker-compose? Apparently this function has been moved into the docker CLI client and is just provided as an alias now: https://docs.docker.com/compose/migrate/

@24367dfa
Copy link
Member

24367dfa commented Feb 1, 2024

Then lets remove the external component from the role. One less thing to keep up to date.

@LeSpocky
Copy link
Member Author

LeSpocky commented Feb 1, 2024

As far as I understood, docker compose v2 is a plugin now, which has to be installed separately. In the back of my head I remember someone questioned if both are compatible? But if we are currently not using it, we should just start over with v2 once a need rises again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants