Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with hierarchy output report #947

Merged
merged 26 commits into from
Feb 4, 2024

Conversation

justin-tay
Copy link
Contributor

This fixes some issues with the hierarchy output report

  • Fixes the incorrect assumption that an evaluation path corresponds to only one instance location
  • Fixes validation messages to be more consistent and more descriptive of the error
  • Fixes to anyOf validator to not short-circuit when annotation collection is enabled

This also makes certain changes to allow for handling certain larger schemas

  • Allowing the initial preloading of schemas to be optional
  • Changes to fail fast in order for the oneOf validator to be able to discard child schema messages.

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (91385c2) 78.92% compared to head (b841234) 78.96%.

Files Patch % Lines
...ava/com/networknt/schema/ItemsValidator202012.java 64.28% 5 Missing ⚠️
...ava/com/networknt/schema/PrefixItemsValidator.java 0.00% 4 Missing ⚠️
...schema/output/HierarchicalOutputUnitFormatter.java 87.09% 1 Missing and 3 partials ⚠️
...ava/com/networknt/schema/output/OutputUnitKey.java 0.00% 3 Missing ⚠️
...a/com/networknt/schema/SchemaValidatorsConfig.java 83.33% 2 Missing ⚠️
...main/java/com/networknt/schema/ItemsValidator.java 94.11% 0 Missing and 1 partial ⚠️
...n/java/com/networknt/schema/JsonSchemaFactory.java 83.33% 0 Missing and 1 partial ⚠️
...n/java/com/networknt/schema/MaxItemsValidator.java 50.00% 1 Missing ⚠️
...n/java/com/networknt/schema/MinItemsValidator.java 50.00% 1 Missing ⚠️
...c/main/java/com/networknt/schema/NotValidator.java 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #947      +/-   ##
============================================
+ Coverage     78.92%   78.96%   +0.04%     
- Complexity     1699     1714      +15     
============================================
  Files           157      157              
  Lines          5669     5710      +41     
  Branches       1071     1076       +5     
============================================
+ Hits           4474     4509      +35     
- Misses          796      802       +6     
  Partials        399      399              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 85d642b into networknt:master Feb 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants