Issue386: FailFast should not cause exception on if #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiemelNaran
reviewed
Nov 24, 2021
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
Can we have all of the test cases in https://json-schema.org/understanding-json-schema/reference/conditionals.html#if-then-else
You could maybe make two arrays like so
{
"passing": [
{ your example above },
{ other passing example from the link },
...
],
"failing": [
{ "data": { a failing example from the link }, "expectedErrors":["error1", "error2"] },
...
}
There was a problem hiding this comment.
I've changed this to have all the tests above in this 'fail fast' test.
I've also updated the draft2019-09/if-then-else.json and draft7/if-then-else.json to have the full set of tests from that link too.
stevehu
changed the title
SiemelNaran
reviewed
Nov 25, 2021
|
@gareth-robinson I don't know if I have merged the PR before you have updated the test cases. If that is the case, please resubmit the PR from your forked branch. The test cases are very important to ensure our code is not going to be broken by others. Thanks. |
|
Excellent!. Thanks a lot for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #386
When failFast is enabled the code that builds the ValidationMessages throws an exception rather than returning a Set.
In if/else/then blocks this could cause the validation to fail whenever an 'if' was false.
I've a basic change here to just wrap the if validation in a try/catch if that's appropriate?
Btw, when running the tests I found that Issue366Test wasn't working, as it was looking in the wrong location (but otherwise is not related to this change)